- 03 Nov, 2019 3 commits
-
-
osm0sis authored
- `!= remain` shouldn't indicate "not signed", it should indicate a read error as with `!= hdr.length` - attempt to catch unsigned images at signature read, before they make it to `BootSignature bootsig = new BootSignature(signature);` and result in the following: java.io.IOException: unexpected end-of-contents marker at org.bouncycastle.asn1.ASN1InputStream.readObject(Unknown Source:14) at com.topjohnwu.signing.SignBoot$BootSignature.<init>(SignBoot.java:230) at com.topjohnwu.signing.SignBoot.verifySignature(SignBoot.java:139) at com.topjohnwu.signing.BootSigner.main(BootSigner.java:15) at a.a.main(a.java:20)
-
osm0sis authored
- change to $TMPDIR in addon.d.sh since recovery addon.d-v1 backup + restore leaves you in /tmp/addon.d which the restore then deletes, which would break $BOOTSIGNER execution with the following: libc: Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 1078 (main), pid 1078 (main) Segmentation fault - also move $BOOTSIGNER execution to after `cd $MAGISKBIN` to ensure it's in a working directory in all cases - addon.d.sh data mount wasn't doing anything since /data has to already be mounted for the script to be running, so move it into /system/addon.d/99-magisk.sh stub script where it might be useful on recoveries that don't mount /data initially Fixes #2013
-
topjohnwu authored
-
- 02 Nov, 2019 7 commits
-
-
Vladimír Kubala authored
-
topjohnwu authored
-
topjohnwu authored
-
topjohnwu authored
-
Oliver Cervera authored
- updated existing strings based on english updates - added new strings
-
osm0sis authored
- increase SignBoot bootimg header version maximum from 4 to 8 (upstream AOSP is already at 3) and make a variable for future ease - hdr read size of 1024 bytes was too small as hdr_v1 and hdr_v2 have increased the used header page areas to 1632 and 1648 bytes, respectively, so raise this to the minimum page size of 2048 and also make a variable for future ease - do not return "not signed" for all caught exceptions, show StackTrace for future debugging then still return false for script purposes - correct "test keys" boot image signing strings (scripts and app) to "verity keys"
-
osm0sis authored
- remove redundant addon.d.sh script bits that were covered elsewhere ($TMPDIR in util_functions.sh, find_dtbo_image in patch_dtbo_image) - refactor addon.d.sh and flash_script.sh for simplicity and readability, and put common flashing script in util_functions.sh (as patch_boot_image), which should greatly help avoid them getting out of sync going forward and fixes compressing ramdisk support and post-patch cleanup for addon.d - add check_data to addon.d.sh since moving stock_boot* and stock_dtbo* backups depend on it and so weren't occuring with addon.d - fix find_manager_apk with working fallback for recovery addon.d execution (where `magisk --sqlite` will not work for hidden Manager), Manager DynAPK hiding, and print a useful log warning if an APK can't be found
-
- 01 Nov, 2019 5 commits
-
-
topjohnwu authored
-
Viktor De Pasquale authored
-
topjohnwu authored
-
topjohnwu authored
-
topjohnwu authored
Close #1654
-
- 31 Oct, 2019 9 commits
-
-
topjohnwu authored
-
topjohnwu authored
Close #1977
-
topjohnwu authored
-
topjohnwu authored
Close #2012
-
John Wu authored
-
John Wu authored
-
osm0sis authored
- support unpack without decompression to allow easy testing of magiskboot's header, structure and hashing handling by comparing repack checksum versus origbootimg - make -n first to match repack
-
Rom authored
-
topjohnwu authored
According to this comment in #1880: https://github.com/topjohnwu/Magisk/issues/1880#issuecomment-546657588 If Linux recycled our PPID, and coincidentally the process that reused the PPID is root, AND init wants to kill the whole process group, magiskd will get killed as a result. There is no real way to block a SIGKILL signal, so we simply make sure our daemon PID is the process group leader by renaming the directory. Close #1880
-
- 30 Oct, 2019 4 commits
-
-
topjohnwu authored
-
topjohnwu authored
-
topjohnwu authored
-
topjohnwu authored
On API 23+, the platform unifies the way to handle drawable resources across processes: all drawables can be passed via Icon. This allows us to send raw bitmap to the system without the need to specify a resource ID. This means that we are allowed to NOT include these drawable resources within our stub APK, since our full APK can draw the images programmatically and send raw bitmaps to the system.
-
- 29 Oct, 2019 3 commits
- 27 Oct, 2019 1 commit
-
-
topjohnwu authored
-
- 26 Oct, 2019 7 commits
-
-
Nathan Muccino authored
The plural form of the words 'documentation' and 'following' are used very rarely if ever and I don't believe that they should be used in this particular context.
-
topjohnwu authored
-
Mevlüt TOPÇU authored
Hi, Merge please Thanks
-
Taras authored
-
topjohnwu authored
-
topjohnwu authored
Some newer recovery ramdisk no longer have /sbin/recovery. Add /system/bin/recovery as an additional indication for recovery. Close #1920
-
topjohnwu authored
-
- 24 Oct, 2019 1 commit
-
-
topjohnwu authored
-