Commit 90666599 authored by Brickner_cp's avatar Brickner_cp

Warnings, Code Analysis and Documentation. 2 warnings left.

parent 6e11b029
...@@ -24,6 +24,7 @@ ...@@ -24,6 +24,7 @@
<Word>codings</Word> <Word>codings</Word>
<Word>datagrams</Word> <Word>datagrams</Word>
<Word>datakit</Word> <Word>datakit</Word>
<Word>dce</Word>
<Word>dcn</Word> <Word>dcn</Word>
<Word>docsis</Word> <Word>docsis</Word>
<Word>dss</Word> <Word>dss</Word>
...@@ -59,6 +60,7 @@ ...@@ -59,6 +60,7 @@
<Word>metricom</Word> <Word>metricom</Word>
<Word>multimegabit</Word> <Word>multimegabit</Word>
<Word>multiprotocol</Word> <Word>multiprotocol</Word>
<Word>nca</Word>
<Word>netmask</Word> <Word>netmask</Word>
<Word>nsa</Word> <Word>nsa</Word>
<Word>osi</Word> <Word>osi</Word>
......
using System; using System;
using System.Globalization;
using PcapDotNet.Base; using PcapDotNet.Base;
namespace PcapDotNet.Packets.Dns namespace PcapDotNet.Packets.Dns
...@@ -84,7 +85,7 @@ namespace PcapDotNet.Packets.Dns ...@@ -84,7 +85,7 @@ namespace PcapDotNet.Packets.Dns
/// </summary> /// </summary>
public override string ToString() public override string ToString()
{ {
return string.Format("{0} {1} {2}", base.ToString(), Ttl, Data); return string.Format(CultureInfo.InvariantCulture, "{0} {1} {2}", base.ToString(), Ttl, Data);
} }
/// <summary> /// <summary>
......
...@@ -84,7 +84,7 @@ namespace PcapDotNet.Packets.Dns ...@@ -84,7 +84,7 @@ namespace PcapDotNet.Packets.Dns
public bool Equals(DnsDomainName other) public bool Equals(DnsDomainName other)
{ {
return other != null && return other != null &&
string.Equals(ToString(), other.ToString(), StringComparison.InvariantCultureIgnoreCase); string.Equals(ToString(), other.ToString(), StringComparison.OrdinalIgnoreCase);
} }
/// <summary> /// <summary>
......
using PcapDotNet.Base; using System.Globalization;
using PcapDotNet.Base;
namespace PcapDotNet.Packets.Dns namespace PcapDotNet.Packets.Dns
{ {
...@@ -88,7 +89,8 @@ namespace PcapDotNet.Packets.Dns ...@@ -88,7 +89,8 @@ namespace PcapDotNet.Packets.Dns
/// </summary> /// </summary>
public override string ToString() public override string ToString()
{ {
return string.Format("{0} {1} {2} {3} {4} {5} {6}", DomainName, DnsType, SendersUdpPayloadSize, ExtendedReturnCode, Version, Flags, Data); return string.Format(CultureInfo.InvariantCulture, "{0} {1} {2} {3} {4} {5} {6}",
DomainName, DnsType, SendersUdpPayloadSize, ExtendedReturnCode, Version, Flags, Data);
} }
internal DnsOptResourceRecord(DnsDomainName domainName, DnsClass dnsClass, int ttl, DnsResourceData data) internal DnsOptResourceRecord(DnsDomainName domainName, DnsClass dnsClass, int ttl, DnsResourceData data)
......
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Globalization;
using PcapDotNet.Base; using PcapDotNet.Base;
namespace PcapDotNet.Packets.Dns namespace PcapDotNet.Packets.Dns
...@@ -75,7 +76,7 @@ namespace PcapDotNet.Packets.Dns ...@@ -75,7 +76,7 @@ namespace PcapDotNet.Packets.Dns
/// </summary> /// </summary>
public override string ToString() public override string ToString()
{ {
return string.Format("{0} {1} {2}", DomainName, DnsType, DnsClass); return string.Format(CultureInfo.InvariantCulture, "{0} {1} {2}", DomainName, DnsType, DnsClass);
} }
internal DnsResourceRecord(DnsDomainName domainName, DnsType type, DnsClass dnsClass) internal DnsResourceRecord(DnsDomainName domainName, DnsType type, DnsClass dnsClass)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment