Commit 37b14243 authored by justcoding121's avatar justcoding121

move dispose; remove references to actice objects after dispose

parent ba28db0b
......@@ -30,7 +30,7 @@ namespace Titanium.Web.Proxy.EventArguments
/// <summary>
/// Holds a reference to proxy response handler method
/// </summary>
private readonly Func<SessionEventArgs, Task> httpResponseHandler;
private Func<SessionEventArgs, Task> httpResponseHandler;
/// <summary>
/// Holds a reference to client
......@@ -522,6 +522,10 @@ namespace Titanium.Web.Proxy.EventArguments
/// </summary>
public void Dispose()
{
httpResponseHandler = null;
CustomUpStreamHttpProxyUsed = null;
CustomUpStreamHttpsProxyUsed = null;
WebSession.Dispose();
}
}
......
......@@ -214,14 +214,10 @@ namespace Titanium.Web.Proxy.Http
/// </summary>
public void Dispose()
{
//not really needed since GC will collect it
//but just to be on safe side
Request.RequestBody = null;
Response.ResponseBody = null;
Request.RequestBodyString = null;
Response.ResponseBodyString = null;
ConnectHeaders = null;
Request.Dispose();
Response.Dispose();
}
}
}
......@@ -9,7 +9,7 @@ namespace Titanium.Web.Proxy.Http
/// <summary>
/// A HTTP(S) request object
/// </summary>
public class Request
public class Request : IDisposable
{
/// <summary>
/// Request Method
......@@ -294,5 +294,20 @@ namespace Titanium.Web.Proxy.Http
RequestHeaders = new Dictionary<string, HttpHeader>(StringComparer.OrdinalIgnoreCase);
NonUniqueRequestHeaders = new Dictionary<string, List<HttpHeader>>(StringComparer.OrdinalIgnoreCase);
}
/// <summary>
/// Dispose off
/// </summary>
public void Dispose()
{
//not really needed since GC will collect it
//but just to be on safe side
RequestHeaders = null;
NonUniqueRequestHeaders = null;
RequestBody = null;
RequestBody = null;
}
}
}
......@@ -10,7 +10,7 @@ namespace Titanium.Web.Proxy.Http
/// <summary>
/// Http(s) response object
/// </summary>
public class Response
public class Response : IDisposable
{
/// <summary>
/// Response Status Code.
......@@ -234,5 +234,20 @@ namespace Titanium.Web.Proxy.Http
ResponseHeaders = new Dictionary<string, HttpHeader>(StringComparer.OrdinalIgnoreCase);
NonUniqueResponseHeaders = new Dictionary<string, List<HttpHeader>>(StringComparer.OrdinalIgnoreCase);
}
/// <summary>
/// Dispose off
/// </summary>
public void Dispose()
{
//not really needed since GC will collect it
//but just to be on safe side
ResponseHeaders = null;
NonUniqueResponseHeaders = null;
ResponseBody = null;
ResponseBodyString = null;
}
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment